Add SecureOptions.VerifyConnection#236
Merged
bestbeforetoday merged 1 commit intohyperledger:mainfrom Mar 8, 2026
Merged
Conversation
Linting flagged a gap in TLS certificate verification using the SecureOptions.VerifyCertificate function, since this is not invoked when connections are resumed. This change introduces a new SecureOptions.VerifyConnection verification function that uses more recent Go standard library features to perform verification on both connection and resume. It also provides access to additional information for more thorough verification. The VerifyConnection function replaces the older VerififyCertificate method of certification verification. The old method is retained for compatibility. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
lint-fix
branch
from
e7da2b4 to
e64e657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linting flagged a gap in TLS certificate verification using the SecureOptions.VerifyCertificate function, since this is not invoked when connections are resumed.
This change introduces a new SecureOptions.VerifyConnection verification function that uses more recent Go standard library features to perform verification on both connection and resume. It also provides access to additional information for more thorough verification.
The VerifyConnection function replaces the older VerififyCertificate method of certification verification. The old method is retained for compatibility.