Skip to content

Fix golangci-lint failures #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bestbeforetoday merged 1 commit into from
Feb 23, 2026
Merged

Fix golangci-lint failures #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ linters:
presets:
- common-false-positives
- std-error-handling
rules:
- path: "_test.go$"
text: "^G703:"
linters:
- gosec
formatters:
enable:
- gofmt
Expand Down
2 changes: 1 addition & 1 deletion internal/osnadmin/httpclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func httpClient(caCertPool *x509.CertPool, tlsClientCert tls.Certificate) *http.

func httpDo(req *http.Request, caCertPool *x509.CertPool, tlsClientCert tls.Certificate) (*http.Response, error) {
client := httpClient(caCertPool, tlsClientCert)
return client.Do(req)
return client.Do(req) //#nosec G704 -- responsibility of client to supply valid URL root.
}

func httpGet(url string, caCertPool *x509.CertPool, tlsClientCert tls.Certificate) (*http.Response, error) {
Expand Down