Merged
Conversation
bestbeforetoday
force-pushed
the
go1.24
branch
4 times, most recently
from
cd8f0f3 to
30d72c9
Compare
Go 1.24 is now the oldest currently supported Go release. - Use specific Uber Mock version to avoid future breakages. - Update actions/setup-go from v5 to v6. - Update Fabric versions for testing to latest releases. - Update Go dependencies. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
go1.24
branch
from
30d72c9 to
eb9ca68
Compare
SamYuan1990
reviewed
Sep 5, 2025
SamYuan1990
previously approved these changes
Sep 5, 2025
Contributor
SamYuan1990
left a comment
SamYuan1990
left a comment
There was a problem hiding this comment.
The code looks good to me, but I noticed that there is a CI failure. @bestbeforetoday I just quest for access to see the error msg. what's that?
Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Member
Author
|
@SamYuan1990 As far as I can tell, it is complaining about vulnerable transitive dependencies, all introduced from I had to ask LFDT staff for access to the Snyk results. It seems to have been recently added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.24 is now the oldest currently supported Go release.