-
Notifications
You must be signed in to change notification settings - Fork 135
standardizes syntax for t/f and makes clear when flag applies #1890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
* adds deprecation notices for clique Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net> * amend to when pow consensus deprecated Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net> * Update docs/private-networks/how-to/configure/consensus/clique.md Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net> * Update docs/private-networks/concepts/poa.md Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net> * Update docs/private-networks/tutorials/clique.md Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net> * responds to review Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net> --------- Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net>
…-docs into 1722c-consistent-syntax merging upstream
|
Running through the logic here ahead of QA round. We have 3 conditions that apply to the boolean CLI options: A. Optional, flag-only OK
B. Required, must be =true|false
C. Optional, must be =true|false
|
|
OK dived in that rabbit hole and came out knowing that there is a great deal that I do not know: CLI Options That Can Be Passed as Flags OnlyThis table shows which CLI options from the provided list can be passed as flags only (e.g.,
Category Definitions
SummaryThe combo of arity + fallbackValue + toggleBooleanFlags(false) gets us close, however, test results clearly show exceptions in both directions. In theory:
Notes
|
|
Closing this: there is no single logic route to identify from code whether flag is accepted where arity is not 1. Only testing can confirm. Will reduce the scope and adjust the original issue. |
Description
Clean up / verification of T/F
Boolean - 2 variants remain
required =<true|false>
optional [=<true|false>], where default is false and passing the boolean is optional, the bash example shows a flag only
Issue(s) fixed
Fixes #partial 1772
Preview