Upgrade react-router-dom version#3586
Merged
pawelperek-da merged 8 commits intomainfrom Jan 21, 2026
Merged
Conversation
Contributor
Author
|
Note: this PR is a little noisy due to |
pawelperek-da
commented
Jan 20, 2026
| await checkActionSelection('Offboard Member', 'SRARC_OffboardSv', 'offboard-sv-action'); | ||
| }); | ||
|
|
||
| test('Feature Application Form is rendered after action selection', async () => { |
Contributor
Author
There was a problem hiding this comment.
Additional unit tests that has been missed in the initial implementation
pawelperek-da
commented
Jan 20, 2026
| @@ -56,6 +57,7 @@ export const Wrapper: React.FC<{ children: React.ReactNode }> = ({ children }) = | |||
| <MemoryRouter> | |||
| <SvConfigProvider> | |||
| <WrapperProviders children={children} /> | |||
| <Toaster richColors /> | |||
Contributor
Author
There was a problem hiding this comment.
Turns out Set DSO/Amulet Rules unit tests didn't test correctly for the toast existence (it tested .toBeDefined() rather than .toBeInTheDocument() which gave false positives)
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
pawelperek-da
force-pushed
the
pawel/3151/react-router-dom-bump
branch
from
0b018ce to
3baefe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/DACH-NY/canton-network-internal/issues/3151
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines