Add dedicated log level flag for ApiRequestLogger#3578
Add dedicated log level flag for ApiRequestLogger#3578julientinguely-da merged 12 commits intomainfrom
Conversation
08fb7d9 to
e040089
Compare
390b54a to
2adc08b
Compare
|
/cluster_test |
|
Deploy cluster test triggered for Commit 7fc3f40aea825719597c5d236fd149f4e2bf0326 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/51523 |
[static] Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
41d6dfa to
4e5bd4a
Compare
|
/cluster_test |
|
Deploy cluster test triggered for Commit 4e5bd4a1075aaea969a1acfdde8c982b1f6a6a57 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/53446 |
[static] Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
[static] Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
|
/cluster_test |
|
Deploy cluster test triggered for Commit ba5bf665e3135a6f5104e27e73d2a1099fb1d941 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/53495 |
|
/cluster_test |
|
Deploy cluster test triggered for Commit 184a340c0f44b151c3daa2adc6045be6f0962d9b in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/53509 |
|
this is working now: see the logs |
[static] Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
| - name: LOG_LEVEL_CANTON | ||
| value: {{ .logLevel | default "INFO" }} | ||
| - name: LOG_API_REQUEST_CANTON | ||
| value: {{ .apiRequestLogLevel | default "DEBUG" }} |
There was a problem hiding this comment.
the magic happens here
moritzkiefer-da
left a comment
There was a problem hiding this comment.
Lgtm, have you checked how close our logback is to the upstream one in Canton? I'm a bit wary of there being potentially more differences than the change you made as we haven't used them for Canton for a while which may come back to bite us.
Let's also upstream this change to Canton.
And now that we enabled info log on CI how about also enabling those request logs there by default?
The diffs is the following, only addition to canton-network.logback: and, all file names going from canton_xxx.clog to canton_network_xxx.clog. But that should be overwritten anyway by env vars. And we don't have KMS-realted logs in canton_network.logback, which is problematic |
|
@moritzkiefer-da I propose we clone canton.clog with our change to make it less conflicting for now, make the require change on canton, and revert once the upstream change is merge? I feel the upstream change might require more changes like adding separate flags etc. |
|
wfm |
…to julien/3036-enable-access-logs-mainnet
filters) [static] Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
…to julien/3036-enable-access-logs-mainnet
They are enabled by default: https://github.com/hyperledger-labs/splice/pull/3578/changes#diff-7f885255a483e1db9d0e10c531a8c4193cb3aac8fea2612d4351f83b6202ad68:~:text=%2B-,apiRequestLogLevel%3A%20DEBUG,-169 |
@moritzkiefer-da would be happy to double check that with you to be sure I'm not breaking anything with this PR |
that's the cluster config not CI config. I mean logs for the Canton instance started by start-canton.sh |
you did run a git diff against the one in the Canton repo and there were no meaningful differences right? if so I think we're good |
| </encoder> | ||
| <filter class="${log_last_errors_filter}" /> | ||
| </appender> | ||
|
|
There was a problem hiding this comment.
@moritzkiefer-da , the only thing that was not present when doing the git diff was the appender for the KMS logs, so adding them here
[ci] Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
Ah understood. So for that I'd need to define a new flag in upstream canton similar to |
or just set the env var? |
|
but if the default is debug that should also be fine |
[ci] Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
[static] Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
fixes https://github.com/DACH-NY/canton-network-internal/issues/3036
logs for scratchnet test: https://console.cloud.google.com/logs/query;query=resource.labels.cluster_name%3D%22cn-scratchbnet%22%0A%22ApiRequestLogger%22%0Aseverity%3DDEBUG%0A%22GetConnectedSynchronizers%22;cursorTimestamp=2026-02-11T10:24:58.130Z;startTime=2026-02-11T09:58:00.000Z;endTime=2026-02-11T12:59:06.985Z?project=da-cn-scratchnet
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines