[ci] Remove /v0/total-amulet-balance and /v0/wallet-balance endpoints by ray-roestenburg-da · Pull Request #3546 · hyperledger-labs/splice

ray-roestenburg-da · 2026-01-14T12:52:37Z

Fixes #3503

Pull Request Checklist

Cluster Testing

If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

Include any change that might be observable by our partners or affect their deployment in the release notes.
Specify fixed issues with Fixes #n, and mention issues worked on using #n
Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

ray-roestenburg-da · 2026-01-14T12:57:47Z

@@ -67,12 +63,6 @@ class HttpTokenStandardMetadataHandler(
      }
  }

-  private def lookupTotalSupplyByLatestRound()(implicit ec: ExecutionContext, tc: TraceContext) =


@OriolMunoz-da please check if these changes (and further below in this file) are OK, (ignoring noHoldingFeesOnTransfers) otherwise I have to keep getTotalAmuletBalance around in the store, but I would prefer to just delete more.

noHoldingFeesOnTransfers.supported is true for all networks now, so you shouldn't need the fallback
the issue is in tests though, because it depends on the latest ACS snapshot which might not be available (as it's computed every 3h)

OriolMunoz-da · 2026-01-14T13:07:20Z

@@ -67,12 +63,6 @@ class HttpTokenStandardMetadataHandler(
      }
  }

-  private def lookupTotalSupplyByLatestRound()(implicit ec: ExecutionContext, tc: TraceContext) =


noHoldingFeesOnTransfers.supported is true for all networks now, so you shouldn't need the fallback
the issue is in tests though, because it depends on the latest ACS snapshot which might not be available (as it's computed every 3h)

OriolMunoz-da · 2026-01-14T13:07:48Z

+            sv1ScanBackend
+              .lookupInstrument("Amulet")
+              .flatMap(_.totalSupply)
+              .valueOrFail("total balance not yet defined")


for example here, how do you know that a snapshot was generated?
(maybe there's a forceSnapshot somewhere that I'm not seeing)

always forcing now in getTotalAmuletBalance in ScanAppReference

moritzkiefer-da

Lgtm minus the comments Oriol already made, thank you!

I assume we already discussed this with product (probably while I was out), if not let's ofc do that so noone gets surprised by it.

moritzkiefer-da · 2026-01-14T13:45:38Z

-            sql"""
-              select greatest(
-                0,
-                sum_cumulative_change_to_initial_amount_as_of_round_zero -


we should also be able to cleanup the dbs and txlog parsers further, perhaps in multiple steps:

make the columns here and in the scan txlog only required for the balances nullable

stop writing those fields

eventually nuke those columns

I'd suggest to move this to separate PRs but let's make sure we push through at least 1 and 2 as it meaningfully simplifies the code.

Good idea, thanks

I'll add another PR follow up for this.

Added #3563 for leftovers

I'll do this later though, rather first see what more can be removed and then simply do it all at once.

moritzkiefer-da · 2026-01-14T13:48:03Z

+
+  - Scan
+
+    - ``/v0/total-amulet-balance`` and ``/v0/wallet-balance`` endpoints have been removed.


I suggest mentioning the replacement endpoints here and also mention that the existing endpoints are already deprecated. "deprecated endpoints have been removed in favor of X" just sounds much nicer than "Y has been removed"

ray-roestenburg-da · 2026-01-15T11:16:17Z

Also removed wallet-balance usage in scan_txlog.py and everything that was using it (removed option --scan-balance-assertions)

ray-roestenburg-da · 2026-01-15T12:54:58Z

FYI I will not merge this until I get OK from Product (we have discussed before, but to be certain)

moritzkiefer-da

thanks!

moritzkiefer-da · 2026-01-15T12:57:41Z

+  )
+  def getTotalAmuletBalance(): Option[BigDecimal] = {
+    val _ = forceAcsSnapshotNow()
+    lookupInstrument("Amulet")


any reason not to make this an error instead of an optional? it seems like we really always expect amulet to be present

yeah can do that, it's only used for testing now anyway

moritzkiefer-da · 2026-01-15T12:57:55Z

+  )
+  def getTotalAmuletBalance(): Option[BigDecimal] = {
+    val _ = forceAcsSnapshotNow()
+    lookupInstrument("Amulet")


nit: read this from whatever config we have for this instead of hardcoding the string

moritzkiefer-da · 2026-01-15T12:59:11Z

@@ -26,7 +26,7 @@
    },
    "../token-standard/dependencies/canton-json-api-v2/openapi-ts-client": {
      "name": "@lfdecentralizedtrust/canton-json-api-v2",
-      "version": "3.4.0-SNAPSHOT",
+      "version": "3.4.8-SNAPSHOT",


not sure I understand why this changed now but it does seem correct 🤷

I also don't know, I did a npmFix and npmLint at some point..

OriolMunoz-da

lgtm, thanks

ray-roestenburg-da · 2026-01-16T12:23:00Z

/cluster_test

github-actions · 2026-01-16T12:23:30Z

Deploy cluster test triggered for Commit 90b485e6f06c872792e27907b008f730a2e4e2ce in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/47691

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

…e/ScanAppReference.scala Co-authored-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com> Signed-off-by: Raymond Roestenburg <98821776+ray-roestenburg-da@users.noreply.github.com>

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

ray-roestenburg-da force-pushed the ray/remove-balance-endpoints/3503 branch from d9b8581 to 291e5fd Compare January 14, 2026 12:55

ray-roestenburg-da commented Jan 14, 2026

View reviewed changes

ray-roestenburg-da requested review from OriolMunoz-da and moritzkiefer-da January 14, 2026 12:58

OriolMunoz-da reviewed Jan 14, 2026

View reviewed changes

moritzkiefer-da reviewed Jan 14, 2026

View reviewed changes

ray-roestenburg-da force-pushed the ray/remove-balance-endpoints/3503 branch 2 times, most recently from 7e1cd6b to c483204 Compare January 15, 2026 12:31

ray-roestenburg-da requested review from OriolMunoz-da and moritzkiefer-da January 15, 2026 12:35

moritzkiefer-da approved these changes Jan 15, 2026

View reviewed changes

ray-roestenburg-da force-pushed the ray/remove-balance-endpoints/3503 branch 2 times, most recently from a9745e9 to b0ad3c4 Compare January 15, 2026 14:16

OriolMunoz-da approved these changes Jan 15, 2026

View reviewed changes

ray-roestenburg-da force-pushed the ray/remove-balance-endpoints/3503 branch 2 times, most recently from 1e57f3a to d4e02d9 Compare January 15, 2026 17:11

ray-roestenburg-da and others added 10 commits January 23, 2026 09:34

[ci] Remove /v0/total-amulet-balance and /v0/wallet-balance endpoints

5c1cb22

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

[ci] npmFix, npmLint

47b250b

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

Removed wallet-balance usage from scan_txlog.py

4cf86a1

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

Updated release notes

7b40721

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

Removed usage of --scan-balance-assertions

108d0a0

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

[ci] Force snapshot in getTotalAmuletBalance

71f6b4d

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

[ci] Fix ts compile errors.

d1e84bf

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

Update apps/app/src/main/scala/org/lfdecentralizedtrust/splice/consol…

1f1a4cc

…e/ScanAppReference.scala Co-authored-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com> Signed-off-by: Raymond Roestenburg <98821776+ray-roestenburg-da@users.noreply.github.com>

[ci] review

c989fd0

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

[static] Fixed formatting

0eb5150

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

ray-roestenburg-da force-pushed the ray/remove-balance-endpoints/3503 branch from 90b485e to 0eb5150 Compare January 23, 2026 09:39

ray-roestenburg-da enabled auto-merge (squash) January 23, 2026 09:41

ray-roestenburg-da merged commit 3b59f60 into main Jan 23, 2026
44 checks passed

ray-roestenburg-da deleted the ray/remove-balance-endpoints/3503 branch January 23, 2026 09:51


		- Scan

		- ``/v0/total-amulet-balance`` and ``/v0/wallet-balance`` endpoints have been removed.

Conversation

ray-roestenburg-da commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Cluster Testing

PR Guidelines

Merge Guidelines

Uh oh!

ray-roestenburg-da Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moritzkiefer-da left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ray-roestenburg-da commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ray-roestenburg-da commented Jan 15, 2026

Uh oh!

moritzkiefer-da left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OriolMunoz-da left a comment

Choose a reason for hiding this comment

Uh oh!

ray-roestenburg-da commented Jan 16, 2026

Uh oh!

github-actions Bot commented Jan 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

ray-roestenburg-da commented Jan 14, 2026 •

edited

Loading

ray-roestenburg-da Jan 14, 2026 •

edited

Loading

ray-roestenburg-da commented Jan 15, 2026 •

edited

Loading