This repository was archived by the owner on Nov 7, 2023. It is now read-only.
update .golangci.yml#259
Merged
nhoriguchi merged 2 commits intoNov 7, 2023
Merged
Conversation
nhoriguchi
force-pushed
the
mr/update-golangci-yml
branch
from
740607e to
9f53e53
Compare
No commits since November 2022 Signed-off-by: Tracy Kuhrt <tracy.a.kuhrt@accenture.com>
nhoriguchi
force-pushed
the
mr/update-golangci-yml
branch
4 times, most recently
from
1e4f244 to
930cc6c
Compare
This change is to forcibly disable some linters to ignore warnings showw in the recent GitHub Action results. This is a bad practice generally speaking, but we do this just to merge "Archive Lab" patch. Drop some os/Go comination for GitHub Action jobs. So if someone want to unarchive this project, they first have to reenable linters and resolve the warnings. Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
nhoriguchi
force-pushed
the
mr/update-golangci-yml
branch
from
930cc6c to
3a82a4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do want to merge #258 to archive this project, but I can't because of failure in GitHub Action (some linters spit warnings like "unused-parameter" and "redefines-builtin-id"). No one cares about CI failures of the project to be archived, so I forcibly disable related linters to ignore them.