Skip to content

oneOf tests for success-caused failures #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RitoG09 wants to merge 2 commits into
base: main
Choose a base branch
from
+253 −12
Draft

oneOf tests for success-caused failures #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
461f477
oneOf tests for success-caused failures
RitoG09 Feb 3, 2026
0f84b74
not, contain test cases added
RitoG09 Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions src/test-suite/tests/contains.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,88 @@
},
"instance": ["foo", 42],
"errors": []
},
{
"description": "contains fails due to too many matching items with success explanations",
"compatibility": "2019",
"schema": {
"contains": { "type": "string" },
"maxContains": 1
},
"instance": [42, "foo", "bar"],
"errors": [
{
"messageId": "contains-exact-message",
"messageParams": {
"minContains": 1,
"maxContains": 1
},
"instanceLocation": "#",
"schemaLocations": ["#/contains", "#/maxContains"],
"alternatives": [
[
{
"messageId": "type-success",
"messageParams": {
"actualType": "string"
},
"instanceLocation": "#/1",
"schemaLocations": ["#/contains/type"]
}
],
[
{
"messageId": "type-success",
"messageParams": {
"actualType": "string"
},
"instanceLocation": "#/2",
"schemaLocations": ["#/contains/type"]
}
]
]
},
{
"description": "contains fails with multiple object matches",
"compatibility": "2019",
"schema": {
"contains": {
"required": ["a"]
},
"maxContains": 1
},
"instance": [{ "a": 1 }, { "a": 2 }],
"errors": [
{
"messageId": "contains-exact-message",
"messageParams": {
"minContains": 1,
"maxContains": 1
},
"instanceLocation": "#",
"schemaLocations": ["#/contains", "#/maxContains"],
"alternatives": [
[
{
"messageId": "required-success",
"messageParams": { "property": "a" },
"instanceLocation": "#/0",
"schemaLocations": ["#/contains/required"]
}
],
[
{
"messageId": "required-success",
"messageParams": { "property": "a" },
"instanceLocation": "#/1",
"schemaLocations": ["#/contains/required"]
}
]
]
}
]
}
]
}
]
}
52 changes: 52 additions & 0 deletions src/test-suite/tests/not.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,58 @@
},
"instance": "foo",
"errors": []
},
{
"description": "not fails with success explanation",
"schema": {
"not": { "pattern": "^a" }
},
"instance": "apple",
"errors": [
{
"messageId": "not-message",
"instanceLocation": "#",
"schemaLocations": ["#/not"],
"alternatives": [
[
{
"messageId": "pattern-success",
"messageParams": {
"pattern": "^a"
},
"instanceLocation": "#",
"schemaLocations": ["#/not/pattern"]
}
]
]
}
]
},
{
"description": "not with nested schema producing a match",
"schema": {
"not": {
"required": ["a"]
}
},
"instance": { "a": 1 },
"errors": [
{
"messageId": "not-message",
"instanceLocation": "#",
"schemaLocations": ["#/not"],
"alternatives": [
[
{
"messageId": "required-success",
"messageParams": { "property": "a" },
"instanceLocation": "#",
"schemaLocations": ["#/not/required"]
}
]
]
}
]
}
]
}
131 changes: 119 additions & 12 deletions src/test-suite/tests/oneOf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@
{
"description": "oneOf",
"schema": {
"oneOf": [
{ "type": "string" },
{ "type": "number" }
]
"oneOf": [{ "type": "string" }, { "type": "number" }]
},
"instance": null,
"errors": [
Expand Down Expand Up @@ -46,10 +43,7 @@
{
"description": "oneOf more than one match",
"schema": {
"oneOf": [
{ "type": "integer" },
{ "type": "number" }
]
"oneOf": [{ "type": "integer" }, { "type": "number" }]
},
"instance": 1,
"errors": [
Expand All @@ -66,13 +60,126 @@
{
"description": "oneOf pass",
"schema": {
"oneOf": [
{ "type": "string" },
{ "type": "number" }
]
"oneOf": [{ "type": "string" }, { "type": "number" }]
},
"instance": 42,
"errors": []
},
{
"description": "oneOf more than one match with success explanations",
"schema": {
"oneOf": [{ "type": "integer" }, { "type": "number" }]
},
"instance": 66,
"errors": [
{
"messageId": "oneOf-message",
"messageParams": { "matchCount": 2 },
"alternatives": [
[
{
"messageId": "type-success",
"messageParams": {
"actualType": "integer"
},
"instanceLocation": "#",
"schemaLocations": ["#/oneOf/0/type"]
}
],
[
{
"messageId": "type-success",
"messageParams": {
"actualType": "number"
},
"instanceLocation": "#",
"schemaLocations": ["#/oneOf/1/type"]
}
]
],
"instanceLocation": "#",
"schemaLocations": ["#/oneOf"]
}
]
},
{
"description": "oneOf more than one match with failed alternatives ignored",
"schema": {
"oneOf": [
{ "required": ["a"] },
{ "required": ["b"] },
{ "required": ["c"] }
]
},
"instance": { "a": 1, "b": 2 },
"errors": [
{
"messageId": "oneOf-message",
"messageParams": { "matchCount": 2 },
"alternatives": [
[
{
"messageId": "required-success",
"messageParams": {
"property": "a"
},
"instanceLocation": "#",
"schemaLocations": ["#/oneOf/0/required"]
}
],
[
{
"messageId": "required-success",
"messageParams": {
"property": "b"
},
"instanceLocation": "#",
"schemaLocations": ["#/oneOf/1/required"]
}
]
],
"instanceLocation": "#",
"schemaLocations": ["#/oneOf"]
}
]
},
{
"description": "nested oneOf producing multiple matches in inner oneOf",
"schema": {
"oneOf": [
{
"oneOf": [{ "required": ["a"] }, { "required": ["b"] }]
},
{ "required": ["c"] }
]
},
"instance": { "a": 1, "b": 2 },
"errors": [
{
"messageId": "oneOf-message",
"messageParams": { "matchCount": 2 },
"instanceLocation": "#",
"schemaLocations": ["#/oneOf/0/oneOf"],
"alternatives": [
[
{
"messageId": "required-success",
"messageParams": { "property": "a" },
"instanceLocation": "#",
"schemaLocations": ["#/oneOf/0/oneOf/0/required"]
}
],
[
{
"messageId": "required-success",
"messageParams": { "property": "b" },
"instanceLocation": "#",
"schemaLocations": ["#/oneOf/0/oneOf/1/required"]
}
]
]
}
]
}
]
}