fix : multipleOf only considers case that fail in allOf#158
Merged
jdesrosiers merged 1 commit intohyperjump-io:mainfrom Feb 3, 2026
Merged
fix : multipleOf only considers case that fail in allOf#158jdesrosiers merged 1 commit intohyperjump-io:mainfrom
jdesrosiers merged 1 commit intohyperjump-io:mainfrom
Conversation
jdesrosiers
approved these changes
Feb 3, 2026
Collaborator
jdesrosiers
left a comment
There was a problem hiding this comment.
Good catch! We found that issue in #155, but it didn't occur to me that this could have the same weakness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue
Currently, the
multipleOferror handler only considers constraints that failed.If a schema has many
multipleOfconstraints (e.g in an allOf), such as:{ "allOf": [ { "multipleOf": 2 }, { "multipleOf": 3 } ] }then,
Expected behaviour
since both are required, the user effectively requires a multiple of 6. The error message should reflect the combined constraint,
even if one of the individual checks passed.The Fix
This PR updates
multipleOferror-handler to:multipleOfconstraints for the given location, regardless of whether they passed or failed.Verification
Test case has been added to cover this.