grpc: fix shutdown ref cycles in Channel and Subchannel#2537
Merged
dfawley merged 2 commits intohyperium:masterfrom Mar 11, 2026
Merged
grpc: fix shutdown ref cycles in Channel and Subchannel#2537dfawley merged 2 commits intohyperium:masterfrom
dfawley merged 2 commits intohyperium:masterfrom
Conversation
- Channel ref cycle: - LbController impl'd WorkScheduler which was given to child LB policy - LbController owns child LB policy directly - Subchannel ref cycle: - Spawned task holds a ref to the InternalSubchannel - Task relies on receiver erroring to exit - Sender is held by the InternalSubchannel, creating a direct reference cycle - Fixed Channel by creating a separate type to impl WorkScheduler - Fixed Subchannel: - Removed the "one task" entirely - Restructured so that an Arc<Mutex<Inner>> handles all the state transitions - Any spawned tasks await a signal that the outer InternalSubchannel was dropped
Collaborator
|
(Notes from in-person discussion)
This refactor should happen on it's own, after this PR. Given that this removes the cyclical references and unblocks us, we're going to push it through. |
nathanielford
approved these changes
Mar 10, 2026
Collaborator
nathanielford
left a comment
There was a problem hiding this comment.
(See previous notes - there is work to simplify this area of code, but the core pain point is handled for now!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel ref cycle:
Subchannel ref cycle:
Fixed Channel by creating a separate type to impl WorkScheduler
Fixed Subchannel: