Add missing license files for the public crates#2531
Open
LecrisUT wants to merge 1 commit intohyperium:masterfrom
Open
Add missing license files for the public crates#2531LecrisUT wants to merge 1 commit intohyperium:masterfrom
LecrisUT wants to merge 1 commit intohyperium:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #2321 (comment), these license symlinks were missed when the crate split happened.
I am not sure if I identified the public crates correctly, but I went by if the crate had a
descriptionor not, (grpc,codegenandinteropwere hence omitted).I need to point out though that the license file is not technically correct for
tonic-protobufbecause it seems the copyright authors do not match (gRPC AuthorsvsLucio Franco). It can be fine if it implies that the contributors have yielded their copyright, butgRPC Authorsbeing quite the external entity, I don't think it applies here? There is even a header with the relevant copyright indicated. That's why I added a new license file in there.Alternatively, you can make the top-level
LICENSEstripped of copyright notice and instead add the copyright notice in the source files themselves. Reuse is also an interesting project to consider to make sure the appropriate license/copyright headers are included.