fix(tonic-prost-build): restore missing emit_rerun_if_changed functionality#2512
Draft
pierrekin wants to merge 1 commit intohyperium:v0.14.xfrom
Draft
fix(tonic-prost-build): restore missing emit_rerun_if_changed functionality#2512pierrekin wants to merge 1 commit intohyperium:v0.14.xfrom
pierrekin wants to merge 1 commit intohyperium:v0.14.xfrom
Conversation
Author
|
After reviewing the code more carefully, I believe it was the intention of the original author to move the implementation to the |
Author
|
A note to reviewers: After reviewing the code more carefully, I believe it was the intention of the original author to move the implementation to prost-build. feat(prost-build): add emit-rerun-if-changed functionality #1402 If my PR is accepted by Tokio, then I think we can continue along that route, if not, we should consider emitting the directives here as per my previous commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solves issue where emit_rerun_if_changed is ignored.
Based on a cursory analysis it seems emit_rerun_if_changed was broken since the tonic-prost-build extraction:
Original implementation: 1d2083a#diff-b0934b805d6c8c11cd87db5e7e77d3e5d2d72d5c72d36e16ce7e99516a8e6b84R435-R449
Extraction commit that lost the implementation: 969408e
Solution
Restores the missing implementation that emits cargo:rerun-if-changed directives for proto files.