Add consistent snake_case/camelCase aliases for is_enabled_for & getEffectiveLevel#797
Open
r266-tech wants to merge 1 commit intohynek:mainfrom
Open
Add consistent snake_case/camelCase aliases for is_enabled_for & getEffectiveLevel#797r266-tech wants to merge 1 commit intohynek:mainfrom
r266-tech wants to merge 1 commit intohynek:mainfrom
Conversation
…ffectiveLevel Fixes hynek#779: BoundLogger and BoundLoggerFilteringAtNotset now both support both / and /. Previously: - BoundLoggerFilteringAtNotset only had snake_case (is_enabled_for, get_effective_level) - BoundLogger only had camelCase (isEnabledFor, getEffectiveLevel) This caused AttributeError when the same code path hit both classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #779
Problem
and have inconsistent method naming:
This causes when the same code path can hit both classes depending on configuration.
Solution
Add aliases so both classes support both naming conventions:
Testing
Verified both naming conventions work and return identical values on both and .