fix: Issue with std lib integration schema in darkmode (documentation)#795
Merged
hynek merged 2 commits intohynek:mainfrom Mar 17, 2026
Merged
fix: Issue with std lib integration schema in darkmode (documentation)#795hynek merged 2 commits intohynek:mainfrom
hynek merged 2 commits intohynek:mainfrom
Conversation
Use only data-theme attribute check instead of also probing prefers-color-scheme via matchMedia. Split the string across lines for readability.
hynek
approved these changes
Mar 17, 2026
Owner
|
Thanks looks good at least on my phone! 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #783
Mermaid diagrams in
docs/conf.pywere always rendered with theneutraltheme regardless of the site's dark mode state. The Sphinx Book Theme setsdocument.documentElement.dataset.themeto'dark'when dark mode is active, butmermaid_init_jsdid not inspect this attribute. Updatesmermaid_init_jsindocs/conf.pyto checkdata-theme === 'dark'and pass the matching Mermaid theme accordingly, falling back to'neutral'for light mode. Verified by inspecting the rendered HTML attribute set by sphinx-book-theme and confirming the ternary covers both states.