Revert "Feat: AICPU launch via dispatcher bootstrap and per-task rtsLaunchCpuKernel"

[ChaoWao]

Reverts #537

[gemini-code-assist]

Code Review

This pull request simplifies the AICPU kernel loading and launch path by removing the transient bootstrap-only dispatcher (libsimpler_aicpu_dispatcher.so) and the host-side LoadAicpuOp loader. The simpler_init API has been updated across all platforms to remove dispatcher-related parameters, and AICPU kernels are now launched directly using rtAicpuKernelLaunchExWithArgs. Feedback on these changes highlights several opportunities to add defensive null-pointer checks for input arguments in launch_aicpu_kernel and simpler_init to prevent potential segmentation faults.

[gemini-code-assist]

Defensively validate k_args and kernel_name pointers before dereferencing them to prevent potential null pointer dereferences and segmentation faults.

int DeviceRunner::launch_aicpu_kernel(rtStream_t stream, KernelArgs *k_args, const char *kernel_name, int aicpu_num) {
    if (k_args == nullptr || kernel_name == nullptr) {
        LOG_ERROR("%s", "Invalid arguments: k_args or kernel_name is null");
        return -1;
    }

    struct Args {
        KernelArgs k_args;
        char kernel_name[32];
        const char so_name[32] = {"libaicpu_extend_kernels.so"};
        const char op_name[32] = {""};
    } args;

    args.k_args = *k_args;
    std::strncpy(args.kernel_name, kernel_name, sizeof(args.kernel_name) - 1);
    args.kernel_name[sizeof(args.kernel_name) - 1] = '\\0';

[gemini-code-assist]

Defensively validate k_args and kernel_name pointers before dereferencing them to prevent potential null pointer dereferences and segmentation faults.

int DeviceRunner::launch_aicpu_kernel(rtStream_t stream, KernelArgs *k_args, const char *kernel_name, int aicpu_num) {
    if (k_args == nullptr || kernel_name == nullptr) {
        LOG_ERROR("%s", "Invalid arguments: k_args or kernel_name is null");
        return -1;
    }

    struct Args {
        KernelArgs k_args;
        char kernel_name[32];
        const char so_name[32] = {"libaicpu_extend_kernels.so"};
        const char op_name[32] = {""};
    } args;

    args.k_args = *k_args;
    std::strncpy(args.kernel_name, kernel_name, sizeof(args.kernel_name) - 1);
    args.kernel_name[sizeof(args.kernel_name) - 1] = '\\0';

[gemini-code-assist]

Defensively validate aicpu_binary and aicore_binary pointers before constructing vectors from them to prevent potential null pointer dereferences.

Suggested change

	int simpler_init(
	DeviceContextHandle ctx, int device_id, const uint8_t *aicpu_binary, size_t aicpu_size,
	const uint8_t *aicore_binary, size_t aicore_size, const uint8_t *dispatcher_binary, size_t dispatcher_size
	const uint8_t *aicore_binary, size_t aicore_size
	) {
	if (ctx == NULL) return -1;
	int simpler_init(
	DeviceContextHandle ctx, int device_id, const uint8_t *aicpu_binary, size_t aicpu_size,
	const uint8_t *aicore_binary, size_t aicore_size
	) {
	if (ctx == nullptr || aicpu_binary == nullptr || aicore_binary == nullptr) return -1;

[gemini-code-assist]

Defensively validate aicpu_binary and aicore_binary pointers before constructing vectors from them to prevent potential null pointer dereferences.

Suggested change

	int simpler_init(
	DeviceContextHandle ctx, int device_id, const uint8_t *aicpu_binary, size_t aicpu_size,
	const uint8_t *aicore_binary, size_t aicore_size, const uint8_t *dispatcher_binary, size_t dispatcher_size
	const uint8_t *aicore_binary, size_t aicore_size
	) {
	if (ctx == NULL) return -1;
	int simpler_init(
	DeviceContextHandle ctx, int device_id, const uint8_t *aicpu_binary, size_t aicpu_size,
	const uint8_t *aicore_binary, size_t aicore_size
	) {
	if (ctx == nullptr || aicpu_binary == nullptr || aicore_binary == nullptr) return -1;

[gemini-code-assist]

Defensively validate aicpu_binary and aicore_binary pointers before constructing vectors from them to prevent potential null pointer dereferences.

Suggested change

	int simpler_init(
	DeviceContextHandle ctx, int device_id, const uint8_t *aicpu_binary, size_t aicpu_size,
	const uint8_t *aicore_binary, size_t aicore_size, const uint8_t *dispatcher_binary, size_t dispatcher_size
	const uint8_t *aicore_binary, size_t aicore_size
	) {
	// Sim has no AICPU dispatcher (the simulator runs AICPU in-process). Accept
	// the parameters for ABI parity with the onboard implementation and ignore
	// them — callers that pass dispatcher bytes get the same shape as onboard,
	// and Mode B path on sim isn't taken anyway.
	(void)dispatcher_binary;
	(void)dispatcher_size;
	if (ctx == NULL) return -1;
	int simpler_init(
	DeviceContextHandle ctx, int device_id, const uint8_t *aicpu_binary, size_t aicpu_size,
	const uint8_t *aicore_binary, size_t aicore_size
	) {
	if (ctx == nullptr || aicpu_binary == nullptr || aicore_binary == nullptr) return -1;

[gemini-code-assist]

Defensively validate aicpu_binary and aicore_binary pointers before constructing vectors from them to prevent potential null pointer dereferences.

Suggested change

	int simpler_init(
	DeviceContextHandle ctx, int device_id, const uint8_t *aicpu_binary, size_t aicpu_size,
	const uint8_t *aicore_binary, size_t aicore_size, const uint8_t *dispatcher_binary, size_t dispatcher_size
	const uint8_t *aicore_binary, size_t aicore_size
	) {
	// Sim has no AICPU dispatcher (the simulator runs AICPU in-process). See
	// a2a3 sim sibling for rationale; parameters accepted for ABI parity.
	(void)dispatcher_binary;
	(void)dispatcher_size;
	if (ctx == NULL) return -1;
	int simpler_init(
	DeviceContextHandle ctx, int device_id, const uint8_t *aicpu_binary, size_t aicpu_size,
	const uint8_t *aicore_binary, size_t aicore_size
	) {
	if (ctx == nullptr || aicpu_binary == nullptr || aicore_binary == nullptr) return -1;