refactor: migrate pl.at(optimization=) to optimizations=[pl.auto_chunk]#373
Conversation
|
Warning Review limit reached
More reviews will be available in 50 minutes and 19 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
📝 WalkthroughWalkthroughThis PR systematically replaces PyPTO's singular ChangesLoop optimization hint unification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request performs a widespread refactor to replace the chunked_loop_optimizer with auto_chunk across multiple example scripts and model implementations. The changes primarily involve updating the pl.at context manager to use the optimizations list parameter instead of the single optimization parameter, along with corresponding updates to docstrings and comments. I have no feedback to provide as there were no review comments.
…izations=[pl.auto_chunk] pypto#1504 removed the pl.at(optimization=, split=) kwargs and the chunked_loop_optimizer sentinel. Switch all callsites to the supported optimizations=[pl.auto_chunk] form and update stale comments. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
auto_chunk requests a ~27GB static arena for rms_norm's two-pass manually-chunked kernel under the pinned pto-isa, failing CI runtime. softmax/layer_norm migrate cleanly (single full-hidden tile); rms_norm is the only example already manually chunked, so revert it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
09a33f0 to
2ea0c63
Compare
…mizer decode_attention_hca/swa wrap pl.at inside an outer pl.range with explicit chunk= args; auto_chunk re-chunks and gives ~34% sim mismatch on x_out (device passes). Same already-manually-chunked case as rms_norm. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
pypto#1504 removed the deprecated
pl.at(optimization=, split=)kwargs and thechunked_loop_optimizersentinel. This migrates every callsite in pypto-lib to the supportedoptimizations=[pl.auto_chunk]form and refreshes stale comments.split=usage existed, so all become a plainoptimizations=[pl.auto_chunk]pl.auto_chunkis itself deprecation-warned but still functional; kept to keep examples runnableTest plan