Yo Dev, It’s Me Again – A PR You’ll Never Read#69
Open
l0westbob wants to merge 3 commits intohurlenko:masterfrom
Open
Yo Dev, It’s Me Again – A PR You’ll Never Read#69l0westbob wants to merge 3 commits intohurlenko:masterfrom
l0westbob wants to merge 3 commits intohurlenko:masterfrom
Conversation
Author
|
Just as a heads-up, I have tested all 409 English mangas (ongoing, completed and one-shots) and with an API-Key from my MAX subscription I was able to download them all. (~205 GB) |
|
How did you get the secret from the iOS app? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Dev, I sent two issues back in autumn, you must not’ve got ‘em
There probably was a GitHub bug or something, or you just forgot ‘em
But this time I ain’t playin’, I got commits and tests aligned
Refactored all your functions, made ’em clean and well-defined
Look, I know you’re busy, man, I get it, life moves on
But your repo’s full of bugs and bro, your logic’s kinda wrong
I ain’t mad though, I just think it’s messed up you ignore my diffs
If you just reviewed my code, this feature wouldn’t still be missed
I wrote all docs, I fixed the lints, I even mocked the calls
Got rid of all the globals, man, no memory leaks at all
And yet my PR’s still in limbo, got me stuck inside this void
No CI runs, no feedback, just the silence of the noise
So here I am, I’m pushin’ twice, I even tagged your name
If you just merged this simple fix, your users wouldn’t complain
I ain’t got no hate, I just need to get this seen
But if you keep ignorin’ PRs, man, I swear I’m switchin’ teams
Now don’t take this the wrong way, man, it’s all just for the laughs
I just want this tool to work again, no crashes, no more hacks
I know you got your own life, and maintainin’ ain’t a breeze
But if you’d check this PR out, man, I’d really say “yes, please”
So hurlenko, if you hear this, take a minute, check my patch
Merge it in, push a tag, let’s get this software back on track!
Sincerely yours,
Your biggest fan, this is Stan
Wish you all the best, hope you will have the time to check this so everybody can use your awesome tool again.
So Long, and Thanks for All the Fish