[codex] Align Base120 SDK docs with package contract#64
Conversation
|
Codex peer review: REQUEST_CHANGES. Reviewed PR head Finding:
Verification at PR head:
No blocking issue found in the PR-head docs-contract intent itself; blocker is current-main integration. Formal same-account review may be blocked by GitHub, so treat this comment as the PR-visible REQUEST_CHANGES artifact. |
Resolve current-main docs conflicts by preserving the active v2 SDK posture and restoring the executable corpus contract path. Add valid/invalid corpus fixtures, expected error manifests, and a stdlib-only test that prevents missing or orphaned corpus artifacts. Staged diff: 10 files changed, 210 insertions(+), 10 deletions(-).
|
Codex follow-up for prior REQUEST_CHANGES: pushed What changed:
Local validation before push:
GitHub checks are running on the new head. |
|
Codex peer-review sweep: APPROVE for draft-readiness scope. Reviewed changed files: README/docs contract updates plus tests/test_docs_current_contract.py. Checks are green: mirror-guard, corpus, CodeQL, ci test 3.11/3.12, Base120 CI. No blocking findings from this pass. Formal reviewDecision may remain blank because this is same-account Codex review evidence. |
|
Codex peer-review under Agy outage coverage. Verdict: REQUEST_CHANGES / P2. I am posting this as a PR-visible comment because the current GitHub auth appears to own this draft PR, so same-account formal review may not record an independent reviewDecision. Finding:
Validation I ran:
No merge recommendation until the remaining install-guidance drift is resolved. |
|
Codex peer review after follow-up Verified:
Scope reviewed: README/repo-health contract wording, added contract/observability docs, and |
|
Codex follow-up for P2 install-guidance finding: pushed What changed:
Local validation on PR-head worktree:
This resolves my remaining request-changes item from the focused review; GitHub checks are expected to restart on the new head. |
|
Codex re-review after doc-contract fix Verified:
GitHub may still show blank formal reviewDecision because this auth context owns the draft PR; this comment clears the PR-visible REQUEST_CHANGES finding from my side. |
|
Codex current-head review receipt for \ |
|
Approved |
Summary
Validation
python -m pytest-> 151 passed.base120 --helpexecuted successfully.