Add S3 action support with labels and improve action display#195
Open
fjerlov-cs wants to merge 2 commits intohumio:masterfrom
Open
Add S3 action support with labels and improve action display#195fjerlov-cs wants to merge 2 commits intohumio:masterfrom
fjerlov-cs wants to merge 2 commits intohumio:masterfrom
Conversation
e96e293 to
1ca3321
Compare
Contributor
Author
|
Running on |
Contributor
Author
|
Running on |
- Add S3Action type with GraphQL mutations, API client support, and version-gated backward compatibility (requires LogScale >= 1.221.0) - Add ListActionsWithoutS3 GraphQL query as a fallback for older servers - Add labels field to all action types and display in list/show commands - Define ActionType constants to replace duplicated string literals - Remove unused getActionLabels function, Labeled interface, and legacy parser APIs - Remove legacy parser version-gating and associated GraphQL operations (LegacyDeleteParserByID, LegacyCreateParser, LegacyGetParser) along with the LogScaleVersionWithParserAPIv2 constant - Remove deprecated isStarred field from alerts - Set Type field on all Add() return values for consistency
1ca3321 to
3d88328
Compare
fjerlov-cs
commented
Feb 19, 2026
| go 1.22.0 | ||
|
|
||
| toolchain go1.22.6 | ||
| go 1.24.0 |
Contributor
Author
There was a problem hiding this comment.
I had problems generating the schema (golang.org/x/tools) with Go 1.26, so I upgraded. I can keep it at 1.22.0 if needed.
Contributor
jespermbyskov
left a comment
There was a problem hiding this comment.
Looking good, nothing looks odd. Someone more familiar with Go should approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add S3 action support, labels for all actions, and clean up dead code
version-gated backward compatibility (requires LogScale >= 1.221.0)
parser APIs
(LegacyDeleteParserByID, LegacyCreateParser, LegacyGetParser) along
with the LogScaleVersionWithParserAPIv2 constant