Reset inner group suppression when outer group changes#26
Merged
billdenney merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Fixes issue 25. When suppress_repeated_groups is TRUE, inner grouping columns were checked against only their own last-seen value with no awareness of outer column changes. For example, with A = c(1,1,2,2) and B = c(3,4,4,4) grouped on A then B, column B would show blank in row 3 even though outer group A had changed. Extracts a new .compute_cell_suppression() helper that precomputes a logical suppression matrix for all group columns. When an outer group column changes, the helper resets inner columns' tracking so their values are re-shown. Replaces the per-column last_grp_val tracking in drawDetails.tfl_table_grob() with a lookup into this matrix. Adds a targeted test for .compute_cell_suppression() that fails before this fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25. When suppress_repeated_groups is TRUE, inner grouping columns were checked against only their own last-seen value with no awareness of outer column changes. For example, with A = c(1,1,2,2) and B = c(3,4,4,4) grouped on A then B, column B would show blank in row 3 even though outer group A had changed.
Extracts a new .compute_cell_suppression() helper that precomputes a logical suppression matrix for all group columns. When an outer group column changes, the helper resets inner columns' tracking so their values are re-shown. Replaces the per-column last_grp_val tracking in drawDetails.tfl_table_grob() with a lookup into this matrix.
Adds a targeted test for .compute_cell_suppression() that fails before this fix.