Improve registration of CLI flags #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow falsy default values for CLI arguments - convert types 'bool' *and* 'boolean' to 'flag'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
empty()to detect whether a CLI argument is optional disallows falsy default values. E.g. optional flags that default to false, as with this plugin's core--resumeand--disable_intermediate_imagesflags.This PR replaces
empty()withisset(), aligning with the behavior inHMCI\Iterator\Base::parse_args().As a bonus, convert both
'bool'and'boolean'argument types to'flag'.