Trigger a PHP warning if an importer or validator is added and its class does not exist #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass does not exist.
tcrsavage
reviewed
Mar 12, 2019
Contributor
tcrsavage
left a comment
tcrsavage
left a comment
There was a problem hiding this comment.
This should probably throw exceptions instead to keep error handling consistent
Member
Author
|
An exception can't be thrown here because there's nothing to catch it. |
Contributor
|
It'd be up to the developer to catch the exception thrown by Master::add_imporer in that case. If not they get a hard failure which I don't see any problem with personally. Fieldmanager uses a very similar approach and I found that quite useful as a developer working ontop of the framework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following currently fails silently. Let's trigger a PHP warning instead.