Fix pagination issue with migrate wp authors CLI command.#121
Open
Fix pagination issue with migrate wp authors CLI command.#121
Conversation
mattheu
force-pushed
the
fix-migrate-authors-query-pagination
branch
from
e95c360 to
dc23c86
Compare
mikelittle
requested changes
Mar 3, 2023
Contributor
mikelittle
left a comment
mikelittle
left a comment
There was a problem hiding this comment.
Comments in the code and I'd suggest a unit test too.
One for each case,
- dry run
- no dry run
- overwrite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mikelittle flagged an issue in my author migration CLI command. Because the command sets the authorship taxonomy, whilst also using a tax query with NOT EXISTS, pagination will cause blocks of users to be skipped.
More detail: after the first 100, it will query for page 2 of more posts. But because the first 100 will no longer be returned by the query, posts 200-300 get skipped.
Solution is to pass pagination param only when doing a dry run, or when overwriting for all (as in this case, no tax query is used)