Conversation
- Change useKey default from false to true in parseHotkey and Options type
- Normalize space key (' ' → 'space') in useKey matching path
- Update tests to reflect new default
With useKey defaulting to true, hotkeys match the produced character
(event.key) instead of the physical key code (event.code). This makes
hotkeys work correctly on non-QWERTY layouts (Dvorak, AZERTY, Colemak)
without requiring callers to pass useKey: true on every call.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…eys-hook into publish-humanlayer
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Version Bump SummaryPackage: @humanlayer/react-hotkeys-hook |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useKeytotrueso hotkeys match produced characters (event.key) instead of physical key codes (event.code)' '→'space') in the useKey matching pathThis is a breaking change for anyone relying on code-based matching as the default, but for our fork this is the desired behavior.
Test plan
🤖 Generated with Claude Code