Redact model config credentials in saved and returned results#1181
Open
yangbaechu wants to merge 1 commit intohuggingface:mainfrom
Open
Redact model config credentials in saved and returned results#1181yangbaechu wants to merge 1 commit intohuggingface:mainfrom
yangbaechu wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR redacts credential fields from
model_configbefore they are exposed through evaluation result artifacts.Specifically, it masks:
api_key(LiteLLM)inference_server_auth(TGI)The redaction is now applied to both:
EvaluationTracker.resultspipeline.get_results()/generate_final_dict()Problem
EvaluationTrackercurrently serializesmodel_configintoconfig_generalwithout redacting credential fields. As a result, values likeapi_keyandinference_server_authcan be persisted in saved result artifacts and exposed throughpipeline.get_results().Changes
api_keyandinference_server_authfrom serializedmodel_configapi_keyis redacted inresultsinference_server_authis redacted inresultsapi_keyis redacted inpipeline.get_results()inference_server_authis redacted inpipeline.get_results()