Open
Conversation
sayakpaul
commented
Mar 31, 2026
Comment on lines
+8
to
+13
| paths: | ||
| - "kernel-builder/**" | ||
| - "kernels/src/**" | ||
| - "nix-builder/**" | ||
| - "kernels-data/**" | ||
| - ".github/workflows/test_e2e.yaml" |
Member
Author
There was a problem hiding this comment.
Trigger on core changes.
sayakpaul
commented
Mar 31, 2026
sayakpaul
commented
Mar 31, 2026
| --name kernels-test/e2e-test-kernel \ | ||
| --backends cuda | ||
|
|
||
| - name: Validate scaffold |
Member
Author
There was a problem hiding this comment.
Happy to remove this check but it's not adding much to the runtime.
sayakpaul
commented
Mar 31, 2026
danieldk
reviewed
Mar 31, 2026
Co-authored-by: Daniël de Kok <me@danieldk.eu>
danieldk
reviewed
Mar 31, 2026
danieldk
reviewed
Mar 31, 2026
sayakpaul
changed the title
drbh
previously approved these changes
Mar 31, 2026
Collaborator
drbh
left a comment
drbh
left a comment
There was a problem hiding this comment.
changes look good to me, pending that the CI issue is resolved
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds fast e2e testing for the kernel builder CLI:
get_kernel()) and use itTo keep the CI runtime manageable, we only build against a single backend. But I think we should also build against a single variant now that #419 is in.