This repository was archived by the owner on Apr 6, 2026. It is now read-only.
feat(windows): allow detecting Python executable#276
Merged
Conversation
MekkCyber
approved these changes
Oct 23, 2025
Comment on lines
+338
to
+342
|
|
||
| # Verify Python and PyTorch version | ||
| $torchVersion = & $pythonExe -c "import torch; print(torch.__version__)" 2>$null | ||
| if ($torchVersion) { | ||
| Write-Status "Detected PyTorch version: $torchVersion" -Type Info |
Contributor
There was a problem hiding this comment.
Just a tiny nit: the code only checks the PyTorch version, not Python, as the comment currently suggests.
Member
Author
There was a problem hiding this comment.
It does detect Python just above:
$pythonExe = (Get-Command python -ErrorAction SilentlyContinue).Sourceand then reuse the Python executable to extract information about PyTorch within the detected python context 😊
Contributor
There was a problem hiding this comment.
Ah, I thought you wanted to print the Python version too in that command! Looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows Windows building script to pick up the current Python executable - useful if using a virtualenv for instance.