Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

fix(windows): always define _WIN32 preprocessor macro to prevent PyTorch compiling unsupported code #275

Merged
mfuntowicz merged 1 commit into from
Oct 23, 2025
Merged

fix(windows): always define _WIN32 preprocessor macro to prevent PyTorch compiling unsupported code #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build2cmake/src/templates/cuda/preamble.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ message(STATUS "Rendered for platform {{ platform }}")
{% if platform == 'windows' %}
include(${CMAKE_CURRENT_LIST_DIR}/cmake/windows.cmake)

# This preprocessor macro should be defined in building with MSVC but not for CUDA and co.
# Also, if not using MVSC, this may not be set too ...
# So we explicitly set it to avoid any side effect due to preprocessor-guards not being defined.
add_compile_definitions(_WIN32>)

# Generate standardized build name
run_python(TORCH_VERSION "import torch; print(torch.__version__.split('+')[0])" "Failed to get Torch version")
run_python(CXX11_ABI_VALUE "import torch; print('TRUE' if torch._C._GLIBCXX_USE_CXX11_ABI else 'FALSE')" "Failed to get CXX11 ABI")
Expand Down
Loading