Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

bug(windows): fix invalid generated build name#274

Merged
mfuntowicz merged 2 commits into
mainfrom
fix-invalid-windows-buildname
Oct 23, 2025
Merged

bug(windows): fix invalid generated build name#274
mfuntowicz merged 2 commits into
mainfrom
fix-invalid-windows-buildname

Conversation

@mfuntowicz
Copy link
Copy Markdown
Member

This PR solves an issue were build name did not include the C11_ABI version along with an invalid "AMD64" arch instead of "x86_64" to match what other platforms have.

@mfuntowicz mfuntowicz requested a review from danieldk October 22, 2025 09:22
MekkCyber
MekkCyber previously approved these changes Oct 23, 2025
Copy link
Copy Markdown
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Comment thread build2cmake/src/templates/xpu/torch-extension.cmake Outdated
@mfuntowicz mfuntowicz merged commit 8ab275b into main Oct 23, 2025
28 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants