Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

feat: Add support for ROCm/HIP flags#262

Merged
danieldk merged 2 commits into
huggingface:mainfrom
shadeMe:feat/config-rocm-flags
Oct 17, 2025
Merged

feat: Add support for ROCm/HIP flags#262
danieldk merged 2 commits into
huggingface:mainfrom
shadeMe:feat/config-rocm-flags

Conversation

@shadeMe
Copy link
Copy Markdown
Contributor

@shadeMe shadeMe commented Oct 16, 2025

Also fixes a small typo. Tested locally (just the build) with flags from the Clang docs.

If you'd like me to add the build.toml config that was used for testing, let me know.

Copy link
Copy Markdown
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Added one small comment. We can later rebase on #264 as a test.

Comment thread build2cmake/src/config/v2.rs Outdated
@shadeMe shadeMe force-pushed the feat/config-rocm-flags branch from 1c2d9bb to 36a884d Compare October 17, 2025 09:30
@shadeMe shadeMe requested a review from danieldk October 17, 2025 09:30
@shadeMe shadeMe changed the title feat: Add support for ROCm flags feat: Add support for ROCm/HIP flags Oct 17, 2025
danieldk
danieldk previously approved these changes Oct 17, 2025
Copy link
Copy Markdown
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@danieldk danieldk merged commit 871987b into huggingface:main Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants