This repository was archived by the owner on Apr 6, 2026. It is now read-only.
Restructure extension to cache extra ROCm and XPU dependencies#257
Merged
Conversation
Before this change the `torch-extension` directory was just a derivation that built an extension for a given configuration + build set. The downside of this approach was that we could not easily get things like - The standard environment to be used by dev shells. - Overrides for caching. For instance, we override ROCm's `clr` and XPU's `oneapi-torch-dev` and `onednn-xpu` to use stdenv with an old glibc. This change modifies `torch-extension` so that we can instantiate it given a build set. A set is returned that can give access to the things mentioned above, as well as mkExtension and mkNoArchExtension functions. We assign this set to the corresponding build set, so that it is directly accessible from the build set.
danieldk
force-pushed
the
cache-extra-deps
branch
from
eda8c76 to
b590c3f
Compare
MekkCyber
approved these changes
Oct 14, 2025
| kernel-abi-check, | ||
| python3, | ||
| rewrite-nix-paths-macho, | ||
| stdenvGlibc_2_27, |
Contributor
There was a problem hiding this comment.
is this a minimal requirement or a strict requirement ?
Member
Author
There was a problem hiding this comment.
We target this version because it was what Torch itself is compiled against (or at least Torch 2.5 or 2.6), it results on working on any glibc version >= 2.27.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change the
torch-extensiondirectory was just a derivation that built an extension for a given configuration + build set. The downside of this approach was that we could not easily get things likeclrand XPU'soneapi-torch-devandonednn-xputo use stdenv with an old glibc.This change modifies
torch-extensionso that we can instantiate it given a build set. A set is returned that can give access to the things mentioned above, as well as mkExtension and mkNoArchExtension functions. We assign this set to the corresponding build set, so that it is directly accessible from the build set.Use this change to add ROCm and XPU overrides to the cache.