This repository was archived by the owner on Apr 6, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Use binary wheels for Torch #252
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
df1d224
Use binary wheels for Torch
danieldk b8314d3
Use the cxxdev output for torch-bin as well
danieldk 25afb1e
Use Torch 2.9 from binary wheels, remove Torch 2.7
danieldk b45e596
Update hf-nix for AArch64 support
danieldk c60f7fd
Use binary Torch 2.9 wheel on macOS
danieldk d047049
Update build variants
danieldk 0a46887
Update tests/docs Torch versions
danieldk 6c9d3eb
CI fixes
danieldk b265b0d
Fix another test that used Torch 2.7
danieldk 6f9e39c
Try to use ubi8 image for tests
danieldk 90ff9a1
Dependencies should be filtered by backend
danieldk a020264
ROCm: use torch-bin
danieldk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -129,7 +129,10 @@ stdenv.mkDerivation (prevAttrs: { | |
| ++ lib.optionals rocmSupport ( | ||
| with rocmPackages; | ||
| [ | ||
| hipcub-devel | ||
| hipsparselt | ||
| rocprim-devel | ||
| rocthrust-devel | ||
| rocwmma-devel | ||
| ] | ||
| ) | ||
|
|
@@ -145,14 +148,7 @@ stdenv.mkDerivation (prevAttrs: { | |
| env = | ||
| lib.optionalAttrs cudaSupport { | ||
| CUDAToolkit_ROOT = "${lib.getDev cudaPackages.cuda_nvcc}"; | ||
| TORCH_CUDA_ARCH_LIST = | ||
| if cudaPackages.cudaOlder "12.8" then | ||
| "7.0;7.5;8.0;8.6;8.9;9.0" | ||
| else if cudaPackages.cudaOlder "13.0" then | ||
| "7.0;7.5;8.0;8.6;8.9;9.0;10.0;10.1;12.0" | ||
| else | ||
| # sm_101 has been renamed to sm_110 in CUDA 13. | ||
| "7.5;8.0;8.6;8.9;9.0;10.0;11.0;12.0"; | ||
| TORCH_CUDA_ARCH_LIST = lib.concatStringsSep ";" torch.cudaCapabilities; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. much cleaner ! very nice |
||
| } | ||
| // lib.optionalAttrs rocmSupport { | ||
| PYTORCH_ROCM_ARCH = lib.concatStringsSep ";" torch.rocmArchs; | ||
|
|
@@ -167,6 +163,9 @@ stdenv.mkDerivation (prevAttrs: { | |
|
|
||
| cmakeFlags = [ | ||
| (lib.cmakeFeature "Python_EXECUTABLE" "${python3.withPackages (ps: [ torch ])}/bin/python") | ||
| # Fix: file RPATH_CHANGE could not write new RPATH, we are rewriting | ||
| # rpaths anyway. | ||
| (lib.cmakeBool "CMAKE_SKIP_RPATH" true) | ||
| ] | ||
| ++ lib.optionals cudaSupport [ | ||
| (lib.cmakeFeature "CMAKE_CUDA_HOST_COMPILER" "${stdenv.cc}/bin/g++") | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit : the torch version in the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I'll update the comments in a separate PR