Change n to m for Y in Enc-Dec section#1942
Open
adenhaus wants to merge 2 commits intohuggingface:mainfrom
Open
Change n to m for Y in Enc-Dec section#1942adenhaus wants to merge 2 commits intohuggingface:mainfrom
adenhaus wants to merge 2 commits intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Encoder-Decoder section of this post, the output sequence$Y$ is introduced as being of length $m$ , i.e. $X$ 's length $n$ instead. But $Y$ does not need to be the same length as $X$ . Later in the article, in the decoder section, the formulas do use $m$ instead of $n$ as the length for $Y$ .
\mathbf{Y}_{1:m}but then inside the following equations, it is denoted as\mathbf{Y}_{1:n}, using the input sequenceSo I believe this is just a mistake and have proposed a fix. Please do let me know if I am mistaken.
Post author: @patrickvonplaten