harbor interop runner addition #478
Draft
nancyjlau wants to merge 3 commits into
Draft
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
6bab8c4 to
f788377
Compare
f788377 to
466cea2
Compare
466cea2 to
4a41ff0
Compare
Replace the Dockerfile-parsing fidelity heuristics (start-script recreation, mkdir-dir restoration, node_modules/vendor/dist submounts, seeded-SQLite restoration, and the hardcoded /app workdir) with a single mechanism: after building the task image, copy its actual working directory onto the host workspace and bind-mount that back over the same guest path. The workspace is then the image's real workdir — source plus every build-generated file, with original mode bits — so nothing the build produced is shadowed by the editable mount, and the guest path is derived from the image's WORKDIR instead of assumed to be /app. This removes ~330 lines of corpus-tuned parsing and makes the runner faithful to any Harbor/terminal-bench image shape rather than the NOVATStyle export specifically. Validated on real Docker across all six artifact classes the heuristics used to cover (compose+postgres, gunicorn start script, node_modules, mkdir dirs, node dist, seeded sqlite): all return reward 0.0 with is_error false and clean teardown. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously the current existing harbor interop is just
integrations.harbor.detect(path)(which just checked whether a folder looked like Harbor tasks) ,integrations.harbor.load(path)(parsed Harbor task folders into a HUD Taskset) , andintegrations.harbor.export(source, out_dir)(being able to export HUD tasks into Harbor folder layout)