Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/server-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change incorrectly replaces a workspace:* dependency with a hardcoded older version (7.1.0). The local version of @storybook/builder-webpack5 in this monorepo is 8.3.0-beta.3. Downgrading to 7.1.0 will cause version mismatches with other @storybook/* packages that are on workspace:* (i.e., 8.3.0-beta.3) and will likely break the build.

While this change is intended to fix a security vulnerability, it's likely to introduce breaking changes. The correct approach would be to address the underlying vulnerability (in the tar package) via yarn resolutions or by updating the transitive dependency chain, rather than downgrading a major component of Storybook.

    "@storybook/builder-webpack5": "workspace:*"

"@storybook/preset-server-webpack": "workspace:*",
"@storybook/server": "workspace:*",
"@types/node": "^22.0.0"
Expand Down
Loading