Skip to content

[Snyk] Fix for 1 vulnerabilities #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: next
Choose a base branch
from
Open

[Snyk] Fix for 1 vulnerabilities #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/frameworks/vue3-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-vite": "workspace:*",
"@storybook/vue3": "workspace:*",
"@storybook/builder-vite": "0.1.22",
"@storybook/vue3": "6.2.0",
Comment on lines +55 to +56
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change is incorrect and will break the project. It replaces workspace:* references with very old, hardcoded versions, which is incompatible with this monorepo's structure. This results in a major downgrade from the workspace version (8.3.0-beta.3) to 0.1.22 and 6.2.0 respectively, which will cause build failures and compatibility issues.

The warning in the PR description about the yarn.lock failing to update confirms this approach is invalid.

The correct way to fix the tar vulnerability (SNYK-JS-TAR-15038581) is to use yarn's resolutions feature in the root package.json to enforce a secure version of tar (e.g., ^6.2.1).

Please reject this change and apply the fix using resolutions. I've suggested reverting these lines to their original state.

Suggested change
"@storybook/builder-vite": "0.1.22",
"@storybook/vue3": "6.2.0",
"@storybook/builder-vite": "workspace:*",
"@storybook/vue3": "workspace:*",

"find-package-json": "^1.2.0",
"magic-string": "^0.30.0",
"typescript": "^5.0.0",
Expand Down
Loading