Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/tech-insights-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@backstage/backend-common": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing a workspace reference with a fixed version (0.1.1) breaks the monorepo's dependency management pattern. This change could lead to version conflicts with other packages that expect to use the same workspace-managed version of @backstage/catalog-model.

Additionally, the PR description indicates that the yarn.lock file failed to update, which must be resolved before merging.

Consider either:

  1. Updating all instances of this package throughout the monorepo to the same version
  2. Maintaining the workspace reference and updating the package version in the root package.json instead

This approach would preserve compatibility while addressing the security vulnerability.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/catalog-model": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-tech-insights-common": "workspace:^",
Expand Down
Loading