Skip to content

[Snyk] Fix for 6 vulnerabilities #10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions plugins/catalog-backend-module-gitlab/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-catalog-node": "1.13.0",
"@backstage/types": "workspace:^",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
Comment on lines +48 to +57
Copy link

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency updates have several critical issues:

  1. yarn.lock not updated: The PR description mentions that yarn.lock has not been updated. Without this, the dependency changes will not be applied, and the vulnerabilities will persist. The lock file must be generated and included in this PR.
  2. Incorrect Downgrades: The versions for @backstage/catalog-model (to 0.1.1) and @backstage/integration (to 0.1.0) are significant downgrades from the versions in the workspace. This will almost certainly cause build failures or runtime errors.
  3. Breaking workspace: protocol: The changes replace workspace:^ with pinned versions. In a monorepo, this is generally incorrect as it can lead to multiple versions of the same package being used, and bypasses the intended workspace linking. The workspace:^ protocol should be preserved.

It seems the automated update process has failed. It's recommended to revert these changes and perform the dependency updates manually, ensuring that workspace: dependencies are respected and that packages are upgraded (not downgraded) correctly. You can likely achieve the desired security fixes by running yarn upgrade-interactive --latest or updating the versions in the root package.json and then running yarn install.

"node-fetch": "^2.6.7",
"uuid": "^8.0.0",
"winston": "^3.2.1"
Expand Down
Loading