Skip to content

[Snyk] Fix for 6 vulnerabilities #10712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

[Snyk] Fix for 6 vulnerabilities #10712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/adr-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.25.0",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-adr-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-adr-common": "0.1.0",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +31 to +39
Copy link

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The change from workspace:^ to pinned versions for internal Backstage packages is incorrect for this monorepo setup. Using workspace:^ ensures that the plugin uses the code from the local workspace, which is crucial for development and consistency within the monorepo.

Pinning to specific versions will cause this package to fetch dependencies from the npm registry instead of using the local versions. This can lead to several problems:

  • Stale Code: Developers won't be testing against the latest changes in other local packages.
  • Dependency Conflicts: It can introduce multiple versions of the same package in the project.
  • Downgrades: Some of the version changes are downgrades, which will likely break the application. For example:
    • @backstage/integration is being changed to 0.1.0 while the workspace version is 1.5.1.
    • @backstage/plugin-adr-common is being changed to 0.1.0 while the workspace version is 0.2.11.
    • @backstage/plugin-search-common is being changed to 0.3.1 while the workspace version is 1.2.5.

This automated change from Snyk seems to misunderstand the yarn workspace setup. These changes should be reverted. To fix the underlying vulnerabilities, the dependencies should be updated across the entire workspace, and then yarn.lock should be regenerated by running yarn install.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-adr-common": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^"

"@types/express": "^4.17.6",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading