Skip to content

[Snyk] Fix for 6 vulnerabilities #10711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/techdocs-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@
"@aws-sdk/lib-storage": "^3.350.0",
"@aws-sdk/node-http-handler": "^3.350.0",
"@aws-sdk/types": "^3.347.0",
"@azure/identity": "^3.2.1",
"@azure/identity": "^3.4.1",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating @azure/identity is good for fixing the vulnerability, please note that other packages in the monorepo, like @backstage/integration in packages/integration/package.json, still use version ^3.2.1. For consistency and to avoid bundling multiple versions of the same package, it would be best to update this dependency across the entire repository.

"@azure/storage-blob": "^12.5.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.25.0",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Changing this dependency from workspace:^ to a fixed version 0.25.0 breaks the monorepo's workspace linking. This package will no longer resolve to the local @backstage/backend-common package. The version 0.25.0 is also a significant jump from the local version 0.19.2-next.0 found in packages/backend-common/package.json, which could introduce breaking changes.

To fix the underlying vulnerability, it's better to keep the workspace:^ protocol and update the transitive dependencies if needed, or update the version of @backstage/backend-common across the monorepo. Snyk's automated change is likely incorrect for this monorepo setup.

Suggested change
"@backstage/backend-common": "0.25.0",
"@backstage/backend-common": "workspace:^",

"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration": "0.1.0",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change from workspace:^ to 0.1.0 is highly problematic. It breaks the workspace linking to the local @backstage/integration package. Furthermore, it's a major downgrade from the local version 1.5.1 (from packages/integration/package.json). This will almost certainly cause breakages.

This change should be reverted. The correct way to fix the vulnerability is to address it within the @backstage/integration package or its dependencies, while maintaining the workspace:^ reference.

Suggested change
"@backstage/integration": "0.1.0",
"@backstage/integration": "workspace:^",

"@backstage/integration-aws-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to the other @backstage/* packages, changing this from workspace:^ to a fixed version 0.3.1 is incorrect for this monorepo setup. It breaks the workspace linking. Please revert this to use the workspace:^ protocol to ensure it resolves to the local package.

Suggested change
"@backstage/plugin-search-common": "0.3.1",
"@backstage/plugin-search-common": "workspace:^",

"@google-cloud/storage": "^6.0.0",
"@trendyol-js/openstack-swift-sdk": "^0.0.6",
"@types/express": "^4.17.6",
Expand Down
Loading