Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/backend-next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,31 +25,31 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-defaults": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-defaults": "0.12.2",
"@backstage/backend-tasks": "0.6.1",
"@backstage/plugin-adr-backend": "workspace:^",
"@backstage/plugin-app-backend": "workspace:^",
"@backstage/plugin-app-backend": "0.1.1",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-azure-devops-backend": "workspace:^",
"@backstage/plugin-badges-backend": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-backend": "0.1.1",
"@backstage/plugin-catalog-backend-module-unprocessed": "workspace:^",
"@backstage/plugin-devtools-backend": "workspace:^",
"@backstage/plugin-entity-feedback-backend": "workspace:^",
"@backstage/plugin-kubernetes-backend": "workspace:^",
"@backstage/plugin-kubernetes-backend": "0.1.1",
"@backstage/plugin-lighthouse-backend": "workspace:^",
"@backstage/plugin-linguist-backend": "workspace:^",
"@backstage/plugin-permission-backend": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-common": "0.1.0",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-backend": "2.2.2",
"@backstage/plugin-search-backend": "workspace:^",
"@backstage/plugin-search-backend-module-catalog": "workspace:^",
"@backstage/plugin-search-backend-module-explore": "workspace:^",
"@backstage/plugin-search-backend-module-techdocs": "workspace:^",
"@backstage/plugin-search-backend-module-techdocs": "0.1.0",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-techdocs-backend": "workspace:^",
"@backstage/plugin-todo-backend": "workspace:^"
"@backstage/plugin-techdocs-backend": "0.1.1",
"@backstage/plugin-todo-backend": "0.1.7"
Comment on lines +28 to +52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change from Snyk incorrectly modifies the dependency management for this monorepo. By replacing workspace:^ with pinned versions, it breaks the Yarn workspace linking.

Problem:
In a monorepo configured with Yarn workspaces, workspace:^ ensures that local packages depend on the code of other packages within the same monorepo. Pinning to a specific version (e.g., "@backstage/backend-defaults": "0.12.2") forces Yarn to fetch that version from the package registry, ignoring any local changes made to the @backstage/backend-defaults package. This can lead to:

  • Developers testing against outdated or incorrect versions of internal packages.
  • Inconsistent behavior between local development and CI/CD builds.
  • Difficult-to-diagnose bugs.

The PR description itself warns: Failed to update the yarn.lock, please update manually before merging. This is a strong indicator that the automated process did not handle the monorepo structure correctly.

Recommendation:
These changes should not be merged as they are. The correct way to address the vulnerabilities is to:

  1. Identify which packages within the workspace need updating.
  2. Update the version field in the package.json of those specific packages.
  3. Run yarn install to update the yarn.lock file and ensure all workspace packages resolve to the correct local versions.

This will fix the vulnerabilities while preserving the integrity of the monorepo setup.

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading