Skip to content

[Snyk] Fix for 6 vulnerabilities #10705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/events-backend-module-gerrit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/plugin-events-node": "0.4.0",
Comment on lines +38 to +39
Copy link

@gemini-code-assist gemini-code-assist bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning internal workspace packages to specific versions is incorrect for this monorepo. It defeats the purpose of using Yarn workspaces with the workspace:^ protocol, which ensures internal packages use the latest code from each other. This change will cause maintenance problems and potential version conflicts.

The proper fix is to:

  1. Identify the vulnerable transitive dependencies within @backstage/backend-plugin-api and @backstage/plugin-events-node.
  2. Update those dependencies in their respective package.json files.
  3. Run yarn install from the monorepo root to update the yarn.lock file.

This automated change should be reverted in favor of the correct manual fix. The PR is also incomplete as the yarn.lock file was not updated.

Suggested change
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/plugin-events-node": "0.4.0",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",

"winston": "^3.2.1"
},
"devDependencies": {
Expand Down
Loading