Skip to content

[Snyk] Fix for 6 vulnerabilities #10704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/backend-app-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/backend-tasks": "0.6.1",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.6.10",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-permission-node": "0.1.0",
Comment on lines +35 to +43
Copy link

@gemini-code-assist gemini-code-assist bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change from Snyk seems to be mishandling the yarn workspace setup. It's replacing workspace:^ dependencies with pinned versions. This breaks the monorepo's dependency management strategy and can lead to several issues:

  • Inconsistent versions: Packages within the monorepo will no longer use the version from the workspace, leading to inconsistencies and potential bugs.
  • Incorrect downgrades: Some of the pinned versions are significant downgrades from the versions currently in the workspace, which will likely cause compilation or runtime errors. For example:
    • @backstage/config-loader is being downgraded from 1.4.0-next.0 to 0.6.10.
    • @backstage/plugin-auth-node is being downgraded from 0.2.17-next.0 to 0.1.0.
    • @backstage/plugin-permission-node is being downgraded from 0.7.11-next.0 to 0.1.0.
  • Maintenance overhead: Manually managing these versions will be difficult in the long run.

The correct way to fix these vulnerabilities is likely to update the affected packages across the entire workspace or update the root dependencies and then run yarn to propagate the changes.

I recommend reverting these changes to the workspace dependencies. The lodash upgrade on line 54 seems correct, but it should be applied along with an update to yarn.lock.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/cli-common": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/config-loader": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^",
    "@backstage/plugin-permission-node": "workspace:^"

"@backstage/types": "workspace:^",
"@manypkg/get-packages": "^1.1.3",
"@types/cors": "^2.8.6",
Expand All @@ -51,7 +51,7 @@
"express-promise-router": "^4.1.0",
"fs-extra": "10.1.0",
"helmet": "^6.0.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"logform": "^2.3.2",
"minimatch": "^5.0.0",
"minimist": "^1.2.5",
Expand Down
Loading