Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/techdocs-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
Comment on lines +38 to +39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependencies have been changed from workspace:^ to a hardcoded, very old version (0.1.0). This is a major regression that will likely break the build and cause runtime issues. In a monorepo using Yarn workspaces, workspace:^ ensures that the package uses the current version of the dependency from within the same repository, which is crucial for consistency and development. Pinning to an old, published version defeats this purpose and introduces outdated code.

This change should be reverted to use the workspace version. The underlying security vulnerability that triggered this change should be investigated and resolved by updating the source package within the workspace if needed, not by pinning to an old version.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",

"@backstage/version-bridge": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/lab": "4.0.0-alpha.61",
"@material-ui/styles": "^4.11.0",
"@types/react": "^16.13.1 || ^17.0.0",
"jss": "~10.10.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"react-helmet": "6.1.0",
"react-use": "^17.2.4"
},
Expand Down
Loading