Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/fossa/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +37 to +41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace:^ dependencies with very old, pinned versions from the public registry. This will break the monorepo structure and likely cause the application to fail to build or run, as it will use outdated versions of internal packages instead of the local versions from the workspace.

For example:

  • @backstage/core-components is being downgraded from a workspace version (which is 0.13.4-next.0 in this monorepo) to 0.1.0.
  • @backstage/plugin-catalog-react is being downgraded to 0.0.1 from a much newer workspace version.
  • @backstage/theme is being downgraded from a workspace version (which is 0.4.1 in this monorepo) to 0.1.1.

These are major downgrades that will introduce breaking changes and regressions. The correct approach to fix the underlying vulnerabilities is to update the dependencies within the monorepo, not to pin them to old public versions. These changes should be reverted.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading