Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/search-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"dependencies": {
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/types": "workspace:^"
"@backstage/types": "0.1.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change downgrades @backstage/types from workspace:^ (which resolves to version 1.1.0 in this monorepo) to a hardcoded version 0.1.1. This is a significant downgrade across major versions (1.x to 0.x) and is likely to introduce breaking changes and inconsistencies.

Using workspace:^ is standard practice in this monorepo to ensure all packages use the same version of internal dependencies. Removing it will cause this package to fetch an old version from the registry, potentially leading to multiple, incompatible versions of @backstage/types in the final build.

While this change is intended to fix security vulnerabilities, this downgrade is a high-risk approach. It's recommended to investigate and fix the vulnerabilities within the current @backstage/types@1.1.0 package or upgrade it if a newer, non-vulnerable version is available, rather than pinning to a very old version. This change should be reverted.

Suggested change
"@backstage/types": "0.1.1"
"@backstage/types": "workspace:^"

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading