Skip to content

[Snyk] Fix for 6 vulnerabilities #10698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/catalog-backend-module-ldap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.13.0",
"@backstage/types": "workspace:^",
"@types/ldapjs": "^2.2.0",
"ldapjs": "^2.2.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
Comment on lines +35 to +44
Copy link

@gemini-code-assist gemini-code-assist bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While the intent to fix vulnerabilities is correct, the approach taken by this automated PR is not suitable for this monorepo.

Incorrect workspace: resolution:
The changes from workspace:^ to pinned versions (e.g., 0.6.1) for @backstage packages are problematic. This breaks the monorepo's local development workflow by forcing the use of published packages from the registry instead of the local source code.

Missing lockfile update:
The PR description correctly notes that yarn.lock has not been updated. Any dependency change must be accompanied by a lockfile update to ensure deterministic installs.

Recommended approach:
This PR should be closed. The vulnerabilities should be fixed manually:

  1. For the @backstage packages, identify the underlying vulnerable dependencies and update them in their respective package.json files within this monorepo.
  2. Update lodash to ^4.17.23 as suggested.
  3. Run yarn install (or equivalent) to generate the updated yarn.lock file.
  4. Submit a new PR with all the package.json changes and the updated yarn.lock file.

This will correctly resolve the vulnerabilities while preserving the integrity of the monorepo setup.

"uuid": "^8.0.0",
"winston": "^3.2.1"
},
Expand Down
Loading