Skip to content

[Snyk] Fix for 6 vulnerabilities #10695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/rollbar-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/backend-common": "0.25.0",
"@backstage/config": "0.1.1",
"@types/express": "^4.17.6",
"compression": "^1.7.4",
"cors": "^2.8.5",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
"fs-extra": "10.1.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
Comment on lines +36 to +44
Copy link

@gemini-code-assist gemini-code-assist bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated PR from Snyk doesn't correctly handle the monorepo's workspace setup and will likely break the build.

  • Incorrectly Pinning Workspace Dependencies: It replaces workspace:^ with pinned versions for @backstage/backend-common and @backstage/config. This breaks the monorepo's dependency linking.
  • Major Version Downgrade: It downgrades @backstage/config from its workspace version (1.0.8) to 0.1.1, which will almost certainly cause breaking changes.
  • Inconsistent Dependency Update: The lodash update is only applied to this package, but it should be handled consistently across the monorepo to be effective. The PR also fails to update yarn.lock.

These changes should be reverted. To fix the vulnerabilities correctly, please update the dependencies at the root of the monorepo and run yarn to update the lockfile.

Suggested change
"@backstage/backend-common": "0.25.0",
"@backstage/config": "0.1.1",
"@types/express": "^4.17.6",
"compression": "^1.7.4",
"cors": "^2.8.5",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
"fs-extra": "10.1.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@types/express": "^4.17.6",
"compression": "^1.7.4",
"cors": "^2.8.5",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
"fs-extra": "10.1.0",
"lodash": "^4.17.21",

"morgan": "^1.10.0",
"node-fetch": "^2.6.7",
"winston": "^3.2.1",
Expand Down
Loading