Skip to content

Fix JSON Content-Type being dropped when single header present #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmw-creator wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix JSON Content-Type being dropped when single header present #1866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions httpie/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,11 @@ def make_request_kwargs(
headers = make_default_headers(args)
if base_headers:
headers.update(base_headers)
# Preserve existing Content-Type when merging user-supplied headers
user_content_type = headers.get('Content-Type')
headers.update(args.headers)
if user_content_type and 'Content-Type' not in args.headers:
headers['Content-Type'] = user_content_type
if args.offline and args.chunked and 'Transfer-Encoding' not in headers:
# When online, we let requests set the header instead to be able more
# easily verify chunking is taking place.
Expand Down
Loading